Conversation
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
Bot
added
awaiting review
docs
Documentation build overview
|
pochmann
changed the title
| <MISSING> | ||
|
|
||
| Sentinel objects are truthy and compare equal only to themselves. They are | ||
| Sentinel objects are true and compare equal only to themselves. They are |
There was a problem hiding this comment.
In this particular context I would say:
| Sentinel objects are true and compare equal only to themselves. They are | |
| Sentinel objects are true in a boolean context and compare equal only to themselves. They are |
There was a problem hiding this comment.
How about "Sentinel objects evaluate as true"?
There was a problem hiding this comment.
Still unnecessary and ugly, if not even wrong. "Are/is true" is how the documentation does it.
| ON | ||
|
|
||
| Truthy values, all equal to the integer ``1``. | ||
| True values, all equal to the integer ``1``. |
There was a problem hiding this comment.
Even though True here is not marked up as being the boolean constant, I think this could still lead to confusion. Since the actual code uses 0 and 1 and not the booleans, I would rephrase this as:
All equal to ``1``, and so true in a boolean context.
There was a problem hiding this comment.
Here we could just drop the mention of boolean altogether and just say "All equal to 1", which is in fact the case. Python programmers will know that 1 is true.
There was a problem hiding this comment.
That sentence describes tkinter's TRUE, YES and ON. Clearly being true is the point, and equality to 1 is a side note. I'd have to see how they're usually used, but saying only "equal to 1" might make people focus on the number value and write worse code.
| OFF | ||
|
|
||
| Falsy values, all equal to the integer ``0``. | ||
| False values, all equal to the integer ``0``. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@bitdancer That's redundant and ugly. No other place does that. And nobody wrote "truthy in a boolean context", either. |
|
Exactly, In our docs we try to make a careful distinction between If you don't like the phrase "in a a boolean context"...I'll make alternate suggestions on the review. |
|
Exactly, true has no styling and is lower case (except at the start of a sentence, of course), whereas |
2 participants
Same issue as previously, just new cases. Python terminology is true/false, not truthy/falsy, as can be seen here:
Truth Value Testing
Boolean Operations — and, or, not
The if statement
The while statement
Boolean operations